Skip to content

enforce ordering of libbeat API server Start/Stop functions #46865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2025
Merged

enforce ordering of libbeat API server Start/Stop functions #46865

merged 5 commits into from
Oct 1, 2025
+143 −22

Conversation

leehinman
Copy link
Contributor

Proposed commit message

Add strict ordering to the libbeat API server Start and Stop functions.

Without this it is possible to start the API server multiple times and for the calling of the Stop function to precede the calling of the Start function.

Not an issue in normal beats but in beats receivers when Start and Stop may be called quickly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

cd libbeat\api
go test . -v -count 1 -run TestOrdering

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 30, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@leehinman leehinman marked this pull request as ready for review September 30, 2025 21:36
@leehinman leehinman requested a review from a team as a code owner September 30, 2025 21:36
AndersonQ
AndersonQ approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the failing tests pass, it's good

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 1, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 1, 2025
orestisfl
orestisfl reviewed Oct 1, 2025
View reviewed changes
@leehinman leehinman added skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-9.1 Automated backport to the 9.1 branch backport-9.2 labels Oct 1, 2025
@leehinman leehinman merged commit 4490460 into elastic:main Oct 1, 2025
211 checks passed
mergify bot pushed a commit that referenced this pull request Oct 1, 2025
@leehinman @mergify
enforce ordering of libbeat API server Start/Stop functions (#46865)
3416ca7 
* enforce ordering of libbeat API server Start/Stop functions

(cherry picked from commit 4490460)
@mergify mergify bot mentioned this pull request Oct 1, 2025
Open
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 1, 2025
@leehinman @mergify
enforce ordering of libbeat API server Start/Stop functions (#46865)
d6e927c 
* enforce ordering of libbeat API server Start/Stop functions

(cherry picked from commit 4490460)
@mergify mergify bot mentioned this pull request Oct 1, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestisfl orestisfl orestisfl left review comments

@AndersonQ AndersonQ AndersonQ approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@leehinman leehinman

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.1 Automated backport to the 9.1 branch backport-9.2 skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leehinman @elasticmachine @AndersonQ @orestisfl @pierrehilbert